FuseMOEExperts. Check if all inputs of postponed_constant are constants #32670
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
category: transformations
praasz
reviewed
Nov 4, 2025
src/common/transformations/src/transformations/common_optimizations/fuse_moe_experts.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| auto fused = std::make_shared<ov::op::v0::Concat>(inputs, 0); | ||
| fused->get_rt_info()["postponed_constant"] = true; | ||
| if (std::all_of(inputs.begin(), inputs.end(), [](const Output<Node>& input) { |
Contributor
There was a problem hiding this comment.
Should it impact on some tests?
Or there should be one to fail without new code.
Contributor
Author
There was a problem hiding this comment.
This is a fix for potential corner case. Right now semantically guarantied that all inputs are constants. But if for example current transformation (or some others) is changed, and behavior is changed as well, we get an error on serialization step.
So no tests are affected right now
olpipi
force-pushed
the
moe_concat_check
branch
from
3fde20b to
4080af0
Compare
olpipi
force-pushed
the
moe_concat_check
branch
from
4080af0 to
372f921
Compare
Contributor
|
That was a temporary solution, maybe it would be better to introduce a more robust way to work with big constants instead of fixing corner cases? |
mryzhov
approved these changes
Nov 7, 2025
praasz
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: